New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseapp: allow for infinite gas when maxGas < 0 #3805

Closed

alessio wants to merge 1 commit into develop from 3791-baseapp-negative-gas-is-not-infinite

Contributor

alessio commented Mar 4, 2019 •

edited

Loading

Closes: #3791

Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)


          baseapp: allow for infinite gas when maxGas < 0

c6d62df

Closes: #3791

alessio requested review from alexanderbez and jackzampolin

March 4, 2019 22:27

alessio requested review from cwgoes, ebuchman and rigelrozanski as code owners

March 4, 2019 22:27

Contributor

alexanderbez commented Mar 4, 2019

Already have an open pr for this: #3801. Sorry I should’ve assigned! 🙊

alessio closed this

alessio deleted the 3791-baseapp-negative-gas-is-not-infinite branch

March 4, 2019 23:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alexanderbez Awaiting requested review from alexanderbez

jackzampolin Awaiting requested review from jackzampolin

cwgoes Awaiting requested review from cwgoes

ebuchman Awaiting requested review from ebuchman

rigelrozanski Awaiting requested review from rigelrozanski

Labels

None yet